Add path traversal protection to serving files example#16
Closed
jtdowney wants to merge 1 commit into
Closed
Conversation
Owner
|
Good to include that, thank you. I pushed the commit where I adjust your changes to my liking. If that looks okay to you, i can close this PR then. :) |
Contributor
Author
|
Looks good |
Owner
|
great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know the comment already addresses this and explains that you needed to do this in production, but my fear is that people will copy and paste the code and ignore it. So why not just make it work correctly even in the example environment? Feel free to close if you don't want this addition.