Repository navigation
feat: add "Clear all" button to History screen - #9
Merged
Merged
Conversation
- Add clearAll() in HistoryViewModel delegating to HistoryRepository.clearAllLogs() - Add trash icon beside History search field, disabled when list is empty - Add confirmation dialog before permanently deleting all notification logs
vssinghh
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Clear all" button to the History screen so users can wipe their entire notification history in one action. For a privacy-first app, clearing your own data should be quick and obvious.
Closes #7
What changed
The data layer already exposed
clearAllLogs()end to end (NotificationLogDao→HistoryRepository→HistoryRepositoryImpl), so this PR only wires up the UI:HistoryViewModel— addclearAll()delegating toHistoryRepository.clearAllLogs(). No new state needed; the existing reactivehistoryLogsflow emits an empty list once the table clears.HistoryScreen— add a trash icon beside the search field (disabled when the list is empty) that opens a confirmation dialog before deleting.Screenshots
How to test
Notes
clearAllLogs()already existed and was only used for retention pruning.