Skip to content

Feat/add clusternames#35

Merged
amandascm merged 1 commit into
mainfrom
feat/add-clusternames
May 27, 2025
Merged

Feat/add clusternames#35
amandascm merged 1 commit into
mainfrom
feat/add-clusternames

Conversation

@amandascm

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

To consider productClusterNames as possible tags for requesting ads (same as productClusterIds).

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (changes configuration files, GitHub workflows, etc.)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@amandascm amandascm requested a review from rodorgas May 27, 2025 16:04
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented May 27, 2025

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

Copy link
Copy Markdown

Beep boop 🤖

I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation

@amandascm amandascm force-pushed the feat/add-clusternames branch from 6d24d24 to 27af787 Compare May 27, 2025 16:05

@rodorgas rodorgas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amandascm amandascm merged commit 68843ed into main May 27, 2025
7 checks passed
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented May 27, 2025

Copy link
Copy Markdown

Your PR has been merged! App is being published. 🚀
Version 2.9.3 → 2.10.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.adserver-resolver@2.10.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants