bugfix "allspecifications" Pseudogroup showing up.#38
Open
kaibrockelt wants to merge 1 commit into
Open
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Contributor
Author
|
Im not able to tick the boxes here. No idea why. so: its a bugfix, so should be a patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The product Context has one Pseudo Group of specifications "allspecifications" that sits along the configured groups. As the name says, it contains ALL specifications again.
The consequence is that in the product comparison table with grouped specifications, any spec listed shows up twice. once in it's corresponding group, and once in the final group "allSpecifications".
The bugfix just adds the condition to skip the allSpecifications item in rendering,
How to test it?
Bugfix applied here:
https://kaibrockelt--ibksport.myvtex.com/bikes?__bindingAddress=ibksport.eu/
Bug visible here:
https://ibksport.myvtex.com/bikes?__bindingAddress=ibksport.eu/
click the little double arrow on 2 products to start comparison. Move to the product-comparison page by clicking compare. See the big fat table at the end? Yep! That is supposed to go after the bugfix,
[Workspace](Link goes here!)
Screenshots or example usage:
Describe alternatives you've considered, if any.
No alternatives. its a buggy bug.
Related to / Depends on
acceptance of a PR. nothing else.
How does this PR make you feel? 🔗