Skip to content

Add user creation if the user is not found#73

Open
razvanudream wants to merge 3 commits intovtex-apps:masterfrom
iviteb:feature/add_user_creation_for_not_found_users
Open

Add user creation if the user is not found#73
razvanudream wants to merge 3 commits intovtex-apps:masterfrom
iviteb:feature/add_user_creation_for_not_found_users

Conversation

@razvanudream
Copy link

What problem is this solving?

When an agent telesales with a non-existent user, it just refreshes the page. There's a PR now that displays an error if a user doesn't exist (#71), however, I think we can go beyond that and simply create the user and use it to login. There's no reason why that shouldn't be a feature, considering that a user is automatically created during the checkout process when an order is placed (An user with just the email provided, no name, nothing else)

How to test it?

Make sure you have telemarketing configured and the appropriate role to your user, link the app and try to use an email that doesn't exist in the "CL" entity. It should create it and log you in with it.

Describe alternatives you've considered, if any.

No other alternatives. This makes sense and makes the lives of our clients' agents alot easier.

How does this PR make you feel? 🔗

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 22, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@digital-forge-mn digital-forge-mn requested a review from a team July 14, 2022 15:52
@digital-forge-mn
Copy link

Created this HK ignore version until the PR is approved - vtex.telemarketing@2.11.2-hkignore.0

@digital-forge-mn
Copy link

Hi @victorhmp could you please help here. This PR is 7months old, we are already using this version on some accounts without issue. It would benefit all clients that use this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants