Add user creation if the user is not found#73
Open
razvanudream wants to merge 3 commits intovtex-apps:masterfrom
Open
Add user creation if the user is not found#73razvanudream wants to merge 3 commits intovtex-apps:masterfrom
razvanudream wants to merge 3 commits intovtex-apps:masterfrom
Conversation
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Created this HK ignore version until the PR is approved - |
|
Hi @victorhmp could you please help here. This PR is 7months old, we are already using this version on some accounts without issue. It would benefit all clients that use this component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
When an agent telesales with a non-existent user, it just refreshes the page. There's a PR now that displays an error if a user doesn't exist (#71), however, I think we can go beyond that and simply create the user and use it to login. There's no reason why that shouldn't be a feature, considering that a user is automatically created during the checkout process when an order is placed (An user with just the email provided, no name, nothing else)
How to test it?
Make sure you have telemarketing configured and the appropriate role to your user, link the app and try to use an email that doesn't exist in the "CL" entity. It should create it and log you in with it.
Describe alternatives you've considered, if any.
No other alternatives. This makes sense and makes the lives of our clients' agents alot easier.
How does this PR make you feel? 🔗