chore: reland PR #1226 + PR #1261 — Netlify deploy probe#1264
Conversation
This reverts commit c8bbee5.
…ndpoint deep links
✅ Deploy Preview for elated-hoover-5c29bf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
All tests were successful! |
Attempt 3a from plans/PR-1226-relanding-investigation.md: removing `revalidate: 86400` from `getStaticProps` keeps the page on pure SSG with `fallback: 'blocking'` and stops Next.js from emitting `___netlify-odb-handler`, which the Netlify Lambda step has been rejecting alongside `___netlify-handler` since PR #1226 merged.
Deploy probe result — Step 3a fixed itConfirmed root cause of the Netlify Lambda 400 failure: the Bisection log on this PR
What this PR keeps from PR #1226All user-facing SEO/indexing wins are preserved:
What this PR drops vs PR #1226
Follow-up worth filing with NetlifyIf you want full ISR re-enabled later, the Netlify support ticket draft is still worth sending — they're the only ones who can tell us which exact AWS Lambda parameter Ready to be marked non-draft when you're happy with it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Experimental commit. Reintroduces revalidate: 86400 on getStaticProps so the API reference page becomes ISR again, which previously bloated each function handler by ~35 MB (ISR-prerendered cache data inlined into the handler bundle). Expectation per postmortem analysis: this deploy preview will fail at AWS Lambda upload with HTTP 400, confirming that the size delta from ISR is what's tripping the Lambda parameter validation introduced on May 14. If the deploy unexpectedly succeeds, the postmortem analysis is wrong and we keep investigating. Will revert if the failure is confirmed.
Hypothesis confirmed by deploy 6a0769aacda68300085ff651 (May 15 18:51 UTC): the build failed at the same Lambda 400 step as before, with `available_functions: []` and two function digests pending upload — identical failure pattern to Step 1 deploy 6a0740c6adee800009cd12c7. Returning the branch to the SSG-only state so the deploy preview is green for review/merge. This reverts commit f3364bb.
Experimental confirmation of root causeRe-added
The toggle is binary: presence of Branch is back on commit |
|
Confirmation deploy ( |
Performance ResultsPage /docs/api-reference/marketplace-protocol#post-/pvt/orders/-orderId-/cancel
Complete results here Page /docs/troubleshooting/my-store-catalog-does-not-show-the-price-range-filter
Complete results here Page /updates/release-notes/new-friendlyid-invoice-field-in-customer-credit-api
Complete results here Page /updates/release-notes/2026-01-12-faststore-webops-enhanced-security-for-variables-and-secrets
Complete results here Overall Performance
|
2 participants
Re-lands PR #1226 + PR #1261 with one concession: ISR disabled
This PR re-applies PR #1226 (API reference SEO/indexing, EDU-16758) together with the deep-link hash-detection fix from PR #1261, on a single branch off post-revert
main. The Netlify deploy preview now passes: deploy-preview-1264--elated-hoover-5c29bf.netlify.app.Root cause of the previous deploy failure
PR #1226 introduced
revalidate: 86400ingetStaticProps, switching the API reference page from SSG to ISR. With Next.js 13.2.4 and@netlify/plugin-nextjsv4 this caused Next.js to emit an additional___netlify-odb-handler(On-Demand Builder handler), and AWS Lambda'sCreateFunctionrejected the resulting bundle with HTTP 400 (Invalid AWS Lambda parameters used in this request). The build phase always succeeded; only the function-registration step failed.This PR drops
revalidate: 86400fromgetStaticProps, keeping the page on pure SSG withfallback: 'blocking'so Next.js no longer emits the ODB handler. That single change unblocks the Netlify deploy.Bisection log on this PR
6a0740c6...Failed to upload file: ___netlify-handler,HTTP Error 400: [PUT /deploys/{deploy_id}/functions/{name}][400] uploadDeployFunction)6a0759be...revalidate: 86400fromgetStaticPropsWhat this PR keeps from PR #1226
All user-facing SEO/indexing wins are preserved:
h1, marked-rendered description, endpoint table).noindexremoved from overview pages.getSiteUrl()helper acrossnext-sitemap.config.js, server sitemap, editor preview, and the API reference page.?endpoint=query-string entries).next.config.jsLit SSR patch for local Windows builds.clientHashdeep-link fix so direct links to#get--endpointrender the endpoint view.What this PR drops vs. PR #1226
revalidate: 86400). The page is now pure SSG withfallback: 'blocking', so new API specs are still generated on first request, and re-deploys regenerate everything. We lose only the once-a-day background refresh — acceptable because OpenAPI specs only change when a deploy ships.Follow-up — re-enabling ISR
Only Netlify support can confirm which exact AWS Lambda parameter the ODB handler bundle violates (function name length,
Layers,EphemeralStorage,Code.ZipFilesize, etc.). With that info we could re-enable ISR safely in a follow-up PR. A support-message draft is prepared; not blocking this PR.Related