Skip to content
This repository was archived by the owner on Feb 8, 2026. It is now read-only.

storage: don't log DSN#128

Merged
RaghavSood merged 1 commit into
mainfrom
fix/dont-log-dsn
Jul 13, 2025
Merged

storage: don't log DSN#128
RaghavSood merged 1 commit into
mainfrom
fix/dont-log-dsn

Conversation

@RaghavSood

@RaghavSood RaghavSood commented Jul 13, 2025

Copy link
Copy Markdown
Contributor

Since we stream logs to graylog now, we shouldn't log the DSN including the password and host details

Summary by CodeRabbit

  • Chores
    • Removed logging of the database connection string during Postgres backend initialization.

Copilot AI review requested due to automatic review settings July 13, 2025 21:28
@coderabbitai

coderabbitai Bot commented Jul 13, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

A log statement that previously printed the Postgres database connection string (DSN) during backend initialization has been removed. All other logic, including error handling and migration, remains unchanged.

Changes

File(s) Change Summary
storage/postgres/db.go Removed DSN log statement during Postgres initialization

Poem

A log once showed our DSN string,
But now it's gone—no more to sing.
Connections made without a trace,
Security now takes its place.
The bunny hops with silent cheer,
Our secrets safe, the code is clear!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9812451 and 99feda7.

📒 Files selected for processing (1)
  • storage/postgres/db.go (0 hunks)
💤 Files with no reviewable changes (1)
  • storage/postgres/db.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: migration-test
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the logging of the full DSN in NewPostgresBackend to prevent sensitive credentials from being sent to Graylog.

  • Removed Info-level log that printed the entire DSN with password and host details.
Comments suppressed due to low confidence (1)

storage/postgres/db.go:24

  • [nitpick] Consider adding a generic connection log at Debug level (e.g., logrus.Debug("Connecting to database")) or sanitize the DSN to redact sensitive parts before logging.
func NewPostgresBackend(dsn string, opts *MigrationOptions) (*PostgresBackend, error) {

@webpiratt webpiratt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaghavSood
RaghavSood merged commit bf8c08c into main Jul 13, 2025
3 checks passed
@RaghavSood
RaghavSood deleted the fix/dont-log-dsn branch July 13, 2025 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants