This repository was archived by the owner on Feb 8, 2026. It is now read-only.
🐛 Small bug fixes for fees #131
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| { | ||
| "verifier": { | ||
| "url": "http://verifier:8080", | ||
| "token": "localhost-apikey", | ||
| "party_prefix": "verifier" | ||
| }, | ||
| "vault_service": { | ||
| "relay": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ require ( | |
| github.com/vultisig/commondata v0.0.0-20250430024109-a2492623ef05 | ||
| github.com/vultisig/mobile-tss-lib v0.0.0-20250316003201-2e7e570a4a74 | ||
| github.com/vultisig/recipes v0.0.0-20250719180414-00d6b1584122 | ||
| github.com/vultisig/verifier v0.0.0-20250719200941-de5b88138d5c | ||
| github.com/vultisig/vultiserver v0.0.0-20250715212748-4b23f9849e4b | ||
| golang.org/x/sync v0.12.0 | ||
| google.golang.org/protobuf v1.36.6 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -745,66 +745,10 @@ github.com/vultisig/go-wrappers v0.0.0-20250403041248-86911e8aa33f h1:124Xlloih1 | |
| github.com/vultisig/go-wrappers v0.0.0-20250403041248-86911e8aa33f/go.mod h1:UfGCxUQW08kiwxyNBiHwXe+ePPuBmHVVS+BS51aU/Jg= | ||
| github.com/vultisig/mobile-tss-lib v0.0.0-20250316003201-2e7e570a4a74 h1:goqwk4nQ/NEVIb3OPP9SUx7/u9ZfsUIcd5fIN/e4DVU= | ||
| github.com/vultisig/mobile-tss-lib v0.0.0-20250316003201-2e7e570a4a74/go.mod h1:nOykk4nOy1L3yXtLSlYvVsgizBnCQ3tR2N5uwGPdvaM= | ||
| github.com/vultisig/recipes v0.0.0-20250719180414-00d6b1584122 h1:pt1wftezaJRC1x1BSBQeVXj4kjLwbz8dw102vX79R3I= | ||
| github.com/vultisig/recipes v0.0.0-20250719180414-00d6b1584122/go.mod h1:Ci29kT+x5vPxLCRvIrbVNzM+JIMjDbVvvaLTzli5kYQ= | ||
| github.com/vultisig/verifier v0.0.0-20250719200941-de5b88138d5c h1:kPH5+uxReDp7OAOUaG6WZxqj0Ujacs2ho5mRmr/qqzY= | ||
| github.com/vultisig/verifier v0.0.0-20250719200941-de5b88138d5c/go.mod h1:9f3yGSZWKZeXn30mU+/brufkbkLoGlFmNLKOpRbQgeI= | ||
| github.com/vultisig/vultiserver v0.0.0-20250715212748-4b23f9849e4b h1:Ed2DOWo8fA0KG6e36rzUmGpxcOQjmWTbxWyvUbI5by8= | ||
| github.com/vultisig/vultiserver v0.0.0-20250715212748-4b23f9849e4b/go.mod h1:HwP2IgW6Mcu/gX8paFuKvfibrGE9UmPgkOFTub6dskM= | ||
| github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q= | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -184,6 +184,19 @@ func (s *SchedulerService) CreateTimeTrigger(ctx context.Context, policy vtypes. | |
| return s.db.CreateTimeTriggerTx(ctx, dbTx, *trigger) | ||
| } | ||
|
|
||
| func (s *SchedulerService) GetScheduleFromPolicy(policy vtypes.PluginPolicy) (*rtypes.Schedule, error) { | ||
| recipe, err := base64.StdEncoding.DecodeString(policy.Recipe) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("base64.StdEncoding.DecodeString: %w", err) | ||
| } | ||
|
|
||
| var p rtypes.Policy | ||
| if err := proto.Unmarshal(recipe, &p); err != nil { | ||
| return nil, fmt.Errorf("failed to parse policy schedule: %w", err) | ||
| } | ||
| return p.Schedule, nil | ||
| } | ||
|
|
||
| func (s *SchedulerService) GetTriggerFromPolicy(policy vtypes.PluginPolicy) (*types.TimeTrigger, error) { | ||
| recipe, err := base64.StdEncoding.DecodeString(policy.Recipe) | ||
| if err != nil { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "password": "password" | ||
| }, | ||
| "block_storage": { | ||
| "host": "http://minio-plugin:9000", | ||
| "region": "us-east-1", | ||
| "access_key": "minioadmin", | ||
| "secret": "minioadmin", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,8 @@ type FeeConfig struct { | |
| CollectorWhitelistAddresses []string `mapstructure:"collector_whitelist_addresses"` // A list of whitelisted addresses for which fee transactions are collected against. These can include previous addresses. Fee plugins with a recipient address that is not in this list will not be processed. | ||
| CollectorAddress string `mapstructure:"collector_address"` // This address is what is used for new policies. Fee policies created with a different address will be rejected. | ||
| MaxFeeAmount uint64 `mapstructure:"max_fee_amount"` // Policies that are created/submitted which do not have this amount will be rejected. | ||
| UsdcAddress string `mapstructure:"usdc_address"` // The address of the USDC token on the Ethereum blockchain. | ||
| VerifierToken string `mapstructure:"verifier_token"` // The token to use for the verifier API. | ||
| } | ||
|
|
||
| type ConfigOption func(*FeeConfig) error | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -9,6 +9,7 @@ import ( | |||||||||||||||||
| "github.com/google/uuid" | ||||||||||||||||||
| "github.com/hibiken/asynq" | ||||||||||||||||||
| "github.com/sirupsen/logrus" | ||||||||||||||||||
| "github.com/vultisig/plugin/internal/keysign" | ||||||||||||||||||
| vcommon "github.com/vultisig/verifier/common" | ||||||||||||||||||
| "github.com/vultisig/verifier/plugin" | ||||||||||||||||||
| "github.com/vultisig/verifier/tx_indexer" | ||||||||||||||||||
|
|
@@ -34,6 +35,7 @@ var _ plugin.Plugin = (*FeePlugin)(nil) | |||||||||||||||||
| type FeePlugin struct { | ||||||||||||||||||
| vaultService *vault.ManagementService | ||||||||||||||||||
| vaultStorage *vault.BlockStorageImp | ||||||||||||||||||
| signer *keysign.Signer | ||||||||||||||||||
| db storage.DatabaseStorage | ||||||||||||||||||
| eth *evm.SDK | ||||||||||||||||||
| logger logrus.FieldLogger | ||||||||||||||||||
|
|
@@ -46,6 +48,7 @@ type FeePlugin struct { | |||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| func NewFeePlugin(db storage.DatabaseStorage, | ||||||||||||||||||
| signer *keysign.Signer, | ||||||||||||||||||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Add nil validation for the signer parameter. Consider adding validation to ensure the signer parameter is not nil, similar to the existing validation for + if signer == nil {
+ return nil, fmt.Errorf("signer cannot be nil")
+ }
+
if db == nil {
return nil, fmt.Errorf("database storage cannot be nil")
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| logger logrus.FieldLogger, | ||||||||||||||||||
| baseConfigPath string, | ||||||||||||||||||
| vaultStorage *vault.BlockStorageImp, | ||||||||||||||||||
|
|
@@ -55,6 +58,7 @@ func NewFeePlugin(db storage.DatabaseStorage, | |||||||||||||||||
| feeConfig *FeeConfig, | ||||||||||||||||||
| encryptionSecret string, | ||||||||||||||||||
| verifierUrl string) (*FeePlugin, error) { | ||||||||||||||||||
|
|
||||||||||||||||||
| if db == nil { | ||||||||||||||||||
| return nil, fmt.Errorf("database storage cannot be nil") | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
@@ -93,6 +97,7 @@ func NewFeePlugin(db storage.DatabaseStorage, | |||||||||||||||||
| return &FeePlugin{ | ||||||||||||||||||
| db: db, | ||||||||||||||||||
| eth: evm.NewSDK(ethEvmChainID, rpcClient, rpcClient.Client()), | ||||||||||||||||||
| signer: signer, | ||||||||||||||||||
| logger: logger.WithField("plugin", "fees"), | ||||||||||||||||||
| config: feeConfig, | ||||||||||||||||||
| verifierApi: verifierApi, | ||||||||||||||||||
|
|
||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this overlaps with another verifier config - non-blocking, largely up to you on how you want to handle this, but maybe worth checking later