Delete old DCA code from plugin repo, it re-implemented in dca repo#155
Conversation
WalkthroughThis PR removes the entire DCA plugin and its related binaries, configurations, schemas, and scripts. It updates schema enum values, deletes CI migration workflow, adjusts buckets and init scripts, and simplifies an API ping message. No additions or refactors beyond removals and minor text change. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
webpiratt
changed the title
plugin repo, it re-implemented in dca repo
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
create_buckets.sh (1)
1-12: Harden the script: add strict mode and readiness check instead of fixed sleepTo make this more robust in CI/containers, avoid a magic sleep and fail fast on errors.
Apply the following diff:
#!/bin/bash +set -euo pipefail -# wait for minio server -sleep 5 - -mc alias set local http://localhost:9000 minioadmin minioadmin +mc alias set local http://localhost:9000 minioadmin minioadmin +# wait until MinIO is ready +for i in {1..60}; do + if mc ls local >/dev/null 2>&1; then + break + fi + sleep 1 +done -buckets="vultisig-payroll vultisig-fee" +buckets=("vultisig-payroll" "vultisig-fee") -for bucket in $buckets; do - mc mb --ignore-existing local/$bucket +for bucket in "${buckets[@]}"; do + mc mb --ignore-existing "local/${bucket}" done
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (16)
.github/workflows/migration-test.yml(0 hunks).gitignore(0 hunks)api/server.go(1 hunks)cmd/dca/server/config.go(0 hunks)cmd/dca/server/main.go(0 hunks)cmd/dca/worker/config.go(0 hunks)cmd/dca/worker/main.go(0 hunks)create_buckets.sh(1 hunks)etc/vultisig/dca.yml(0 hunks)init-scripts/01_create_vultisig_plugin.sql(1 hunks)plugin/dca/config.go(0 hunks)plugin/dca/dca.go(0 hunks)plugin/dca/dcaPluginUiSchema.json(0 hunks)plugin/dca/policy.go(0 hunks)scripts/dev/create_dca_policy/main.go(0 hunks)storage/postgres/schema/schema.sql(0 hunks)
💤 Files with no reviewable changes (13)
- plugin/dca/config.go
- .github/workflows/migration-test.yml
- cmd/dca/server/main.go
- plugin/dca/policy.go
- cmd/dca/worker/main.go
- storage/postgres/schema/schema.sql
- cmd/dca/server/config.go
- plugin/dca/dcaPluginUiSchema.json
- etc/vultisig/dca.yml
- cmd/dca/worker/config.go
- .gitignore
- plugin/dca/dca.go
- scripts/dev/create_dca_policy/main.go
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-24T19:34:47.441Z
Learnt from: webpiratt
PR: vultisig/plugin#141
File: plugin/payroll/transaction.go:208-267
Timestamp: 2025-07-24T19:34:47.441Z
Learning: In the vultisig/plugin codebase, duplicate transaction prevention for the payroll plugin has been moved to the verifier side, so the local `IsAlreadyProposed` check in plugin/payroll/transaction.go is no longer needed. The validation flow has changed and is now handled by the verifier rather than within the plugin itself.
Applied to files:
init-scripts/01_create_vultisig_plugin.sql
🔇 Additional comments (4)
create_buckets.sh (2)
8-8: Bucket removal aligns with DCA deprecationRemoving vultisig-dca from the buckets list is consistent with the overall DCA cleanup. No functional concerns.
8-8: No remaining references to "vultisig-dca" — verifiedSearched the repo (case-insensitive) for "vultisig-dca" — no matches. create_buckets.sh sets buckets="vultisig-payroll vultisig-fee". The only "dca" mention is a TODO comment in api/plugin.go (not creating/using a bucket). No further action required.
init-scripts/01_create_vultisig_plugin.sql (2)
1-2: DB list correctly excludes DCACreation now only includes payroll and fee DBs, matching the DCA removal scope.
1-2: Verified — no remaining references to "vultisig-dca"Searched the repo for "vultisig-dca" and common variants (regex: vultisig[-_ ]?dca / vultisig-dca-0000) — no matches. The init script now creates vultisig-payroll and vultisig-fee and configs reference those names.
Files observed for context:
- init-scripts/01_create_vultisig_plugin.sql — CREATE DATABASE "vultisig-payroll"; CREATE DATABASE "vultisig-fee";
- storage/postgres/schema/schema.sql — plugin_id enum contains 'vultisig-payroll-0000' and 'vultisig-fees-feee'
- docker-compose.yaml, .example.json, and .run/.xml — DSNs and buckets reference vultisig-payroll / vultisig-fee
No further action required.
2 participants
Closes: #154
Summary by CodeRabbit
Deprecations/Removals
Changes
Chores