This repository was archived by the owner on Feb 8, 2026. It is now read-only.
🚚 Latest type imports, fixed names and policy version #93
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,63 @@ | ||||||||||||||||||||
| package fees | ||||||||||||||||||||
|
|
||||||||||||||||||||
| import ( | ||||||||||||||||||||
| "errors" | ||||||||||||||||||||
| "fmt" | ||||||||||||||||||||
| "strings" | ||||||||||||||||||||
|
|
||||||||||||||||||||
| "github.com/spf13/viper" | ||||||||||||||||||||
| ) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| type PluginConfig struct { | ||||||||||||||||||||
| Type string `mapstructure:"type"` | ||||||||||||||||||||
| Version string `mapstructure:"version"` | ||||||||||||||||||||
| RpcURL string `mapstructure:"rpc_url"` // URL for the RPC endpoint to interact with the ethereum/evm blockchain | ||||||||||||||||||||
| USDCAddress string `mapstructure:"usdc_address"` // If a non-ethereum chain is used, this is the address of the USDC token contract on that chain | ||||||||||||||||||||
| Gas struct { | ||||||||||||||||||||
| LimitMultiplier int `mapstructure:"limit_multiplier"` | ||||||||||||||||||||
| PriceMultiplier int `mapstructure:"price_multiplier"` | ||||||||||||||||||||
| } `mapstructure:"gas"` | ||||||||||||||||||||
| Monitoring struct { | ||||||||||||||||||||
| TimeoutMinutes int `mapstructure:"timeout_minutes"` | ||||||||||||||||||||
| CheckIntervalSeconds int `mapstructure:"check_interval_seconds"` | ||||||||||||||||||||
| } `mapstructure:"monitoring"` | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| func loadPluginConfig(basePath string) (*PluginConfig, error) { | ||||||||||||||||||||
| v := viper.New() | ||||||||||||||||||||
| v.SetConfigName("fees") | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // Add config paths in order of precedence | ||||||||||||||||||||
| if basePath != "" { | ||||||||||||||||||||
| v.AddConfigPath(basePath) | ||||||||||||||||||||
| } | ||||||||||||||||||||
| v.AddConfigPath(".") | ||||||||||||||||||||
| v.AddConfigPath("/etc/vultisig") | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // Enable environment variable overrides | ||||||||||||||||||||
| v.AutomaticEnv() | ||||||||||||||||||||
| v.SetEnvPrefix("FEES") | ||||||||||||||||||||
| v.SetEnvKeyReplacer(strings.NewReplacer(".", "_")) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| if err := v.ReadInConfig(); err != nil { | ||||||||||||||||||||
| return nil, fmt.Errorf("failed to read config: %w", err) | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| var config PluginConfig | ||||||||||||||||||||
| if err := v.Unmarshal(&config); err != nil { | ||||||||||||||||||||
| return nil, fmt.Errorf("failed to unmarshal config: %w", err) | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // Validate configuration | ||||||||||||||||||||
| if config.Type != PLUGIN_TYPE { | ||||||||||||||||||||
| return nil, fmt.Errorf("invalid plugin type: %s", config.Type) | ||||||||||||||||||||
| } | ||||||||||||||||||||
| if config.RpcURL == "" { | ||||||||||||||||||||
| return nil, errors.New("rpc_url is required") | ||||||||||||||||||||
| } | ||||||||||||||||||||
| if config.Gas.LimitMultiplier <= 0 { | ||||||||||||||||||||
| return nil, errors.New("gas limit multiplier must be positive") | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Comment on lines
+58
to
+60
Contributor
There was a problem hiding this comment. Validate
-if config.Gas.LimitMultiplier <= 0 {
- return nil, errors.New("gas limit multiplier must be positive")
+if config.Gas.LimitMultiplier <= 0 {
+ return nil, errors.New("gas limit multiplier must be positive")
+}
+if config.Gas.PriceMultiplier <= 0 {
+ return nil, errors.New("gas price multiplier must be positive")
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
|
|
||||||||||||||||||||
| return &config, nil | ||||||||||||||||||||
| } | ||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package fees | ||
|
|
||
| const PLUGIN_TYPE = "fees" | ||
| const erc20ABI = `[{ | ||
| "name": "transfer", | ||
| "type": "function", | ||
| "inputs": [ | ||
| {"name": "recipient", "type": "address"}, | ||
| {"name": "amount", "type": "uint256"} | ||
| ], | ||
| "outputs": [{"name": "", "type": "bool"}] | ||
| }]` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package fees | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/ethereum/go-ethereum/ethclient" | ||
| "github.com/sirupsen/logrus" | ||
| "github.com/vultisig/mobile-tss-lib/tss" | ||
| "github.com/vultisig/verifier/plugin" | ||
| "github.com/vultisig/verifier/types" | ||
|
|
||
| "github.com/vultisig/plugin/storage" | ||
| rtypes "github.com/vultisig/recipes/types" | ||
| ) | ||
|
|
||
| var _ plugin.Plugin = (*FeePlugin)(nil) | ||
|
|
||
| type FeePlugin struct { | ||
| db storage.DatabaseStorage | ||
| rpcClient *ethclient.Client | ||
| logger logrus.FieldLogger | ||
| config *PluginConfig | ||
| } | ||
|
|
||
| func NewFeePlugin(db storage.DatabaseStorage, baseConfigPath string) (*FeePlugin, error) { | ||
| if db == nil { | ||
| return nil, fmt.Errorf("database storage cannot be nil") | ||
| } | ||
| cfg, err := loadPluginConfig(baseConfigPath) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to load plugin config: %w", err) | ||
| } | ||
|
|
||
| rpcClient, err := ethclient.Dial(cfg.RpcURL) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &FeePlugin{ | ||
| db: db, | ||
| rpcClient: rpcClient, | ||
| logger: logrus.WithField("plugin", "payroll"), | ||
| config: cfg, | ||
| }, nil | ||
|
Comment on lines
+40
to
+45
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Remember to close the
🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| func (fp *FeePlugin) GetRecipeSpecification() rtypes.RecipeSchema { | ||
| fp.logger.Debug("Getting recipe specification") | ||
| //TODO garry | ||
| return rtypes.RecipeSchema{ | ||
| PluginId: "vultisig-fees-0000", | ||
| Version: 1, | ||
| } | ||
| } | ||
|
|
||
| func (fp *FeePlugin) ValidatePluginPolicy(policyDoc types.PluginPolicy) error { | ||
| return nil | ||
| } | ||
| func (fp *FeePlugin) ProposeTransactions(policy types.PluginPolicy) ([]types.PluginKeysignRequest, error) { | ||
| return []types.PluginKeysignRequest{}, nil | ||
| } | ||
| func (fp *FeePlugin) ValidateProposedTransactions(policy types.PluginPolicy, txs []types.PluginKeysignRequest) error { | ||
| return nil | ||
| } | ||
| func (fp *FeePlugin) SigningComplete(ctx context.Context, signature tss.KeysignResponse, signRequest types.PluginKeysignRequest, policy types.PluginPolicy) error { | ||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Differentiate between “file not found” and real config parse errors
v.ReadInConfig()returns an error when the config file is missing.Right now any error aborts startup, even when users intend to rely solely on environment variables. Handle
viper.ConfigFileNotFoundErrorexplicitly so env-only setups still work.📝 Committable suggestion
🤖 Prompt for AI Agents