doc: explicitly document that id_col defines the output column name#43
Draft
Copilot wants to merge 2 commits into
Draft
doc: explicitly document that id_col defines the output column name#43Copilot wants to merge 2 commits into
id_col defines the output column name#43Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/vvcb/comorbidipy/sessions/29d7f48f-2fd0-4a62-8dea-c4f660708f2a Co-authored-by: vvcb <8311806+vvcb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unexpected ID column name propagation in comorbidity output
doc: explicitly document that May 9, 2026
id_col defines the output column name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
id_colin all three calculators acts as both an input column selector and an output schema contract — the returned DataFrame carries that exact column name — but this was never stated in any docstring or API reference, causing silent schema surprises in downstream pipelines.Changes
comorbidity(),hfrs(),disability()): expandedid_coldescription to state explicitly that the value is used verbatim as the output column name; no renaming occurs.docs/api.md: same note added to all three function entries;Returnsbullets updated from "Patient ID (original column name)" → "Patient ID (column name matchesid_colparameter)".test_custom_id_col_name_preserved_in_outputto assert that a non-defaultid_col(e.g."PATIENT_ID") appears as the first column of the result.Behaviour (unchanged)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either: