Repository navigation
main is red: #231 added LlmResult.usage but tool_validation_tests.rs initializers were not updated (3× E0063) #233
Description
What
origin/main at 32caee82 (and the two CI runs after it) fails to compile the lib test target with 3× E0063. CI on main is red: runs 34158726515 (20:15Z) and 34158245747 (20:08Z) both conclude failure; the last green main run was 18:41Z, before this commit cluster landed.
error[E0063]: missing field `usage` in initializer of `adapter::LlmResult`
--> src/agent/tool_validation_tests.rs:63:19
--> src/agent/tool_validation_tests.rs:72:16
--> src/agent/tool_validation_tests.rs:81:16
error: could not compile `llxprt-code-rs` (lib test) due to 3 previous errors
Why
78f44bc3 (#231, "Carry usage counters through LlmResult") added the required usage: LlmUsage field to adapter::LlmResult and updated src/agent/tests.rs, but src/agent/tool_validation_tests.rs still constructs LlmResult { text, calls, finish_reason } without usage. That file was extended the same cluster by 35341e51 (#221/#225), so the two owner commits collided on the same module without a compile of the lib test target in between.
Repro on a clean checkout of 32caee82:
cargo +1.88 check --workspace --all-targets
Scope note
Downstream integration work (issue #66 lane) reproduced this independently; the three error sites are byte-identical to origin/main (no local diff touches that file), so this is an upstream defect, not integration fallout. Not fixing it here to avoid a duplicate owner-lane patch.
Activity
acoliver commentedon Sep 7, 2026
Disposition update (resolution evidence, not a standalone patch): the
usageinitializers insrc/agent/tool_validation_tests.rsare fixed onorigin/mainby the #64/#224 + #76/#227 cluster (now at66e51049).Independent verification from the #66 integration branch (
issue66-live-tool-evidence-integratedat2566994a, which merges66e51049):git diff origin/main -- src/agent/tool_validation_tests.rsis empty (byte-identical, no local patch).cargo +1.88 check --workspace --all-targetsrc 0 andcargo +1.88 clippy --workspace --all-targets --all-features -- -D warningsrc 0 — the lib unit-test target compiles clean again.Nothing was changed locally to fix this file; the fix arrived via the owner's own merges.
acoliver commentedon Sep 9, 2026
Ownership linkage, no separate lane dispatched: the affected file
src/agent/tool_validation_tests.rsis owned by open PR #245 (tool-validation lane, files includesrc/agent/tool_validation.rsandsrc/agent/tool_validation_tests.rs). The E0063 initializer updates belong in that PR's next exact-head validation before merge rather than a parallel patch. This coordinator will not touch that path while #245 is open.acoliver commentedon Oct 11, 2026
This is resolved on
main. TheLlmResultinitializers insrc/agent/tool_validation_tests.rsnow setusage: LlmUsage::default()(for example lines 25, 37, 45, 75 and 86 ata69e3a20), and CI onmainata69e3a20passed. Closing.