Skip to content

branch4 shared-repair tracking (was PR 296): #286 profile ownership - #300

Closed
acoliver wants to merge 6 commits into
mainfrom
branch4-issue286-profile-ownership
Closed

acoliver wants to merge 6 commits into
mainfrom
branch4-issue286-profile-ownership

Conversation

@acoliver

@acoliver acoliver commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Recreated after the llxprt account suspension removed original PRs #296 (this branch, #286) and #285 (already merged as main commit, now superseded by newer main). Head 29905a23605b177ccd8a238a539664ddee10884b on restored branch branch4-issue286-profile-ownership.

#286 profile ownership: typed host settings (Chat/Anthropic/OpenAI Responses/Codex) so shell default/max reach runtime (-1 removes profile cap, not native safety budgets), provider timeout reaches requests, image policy validated; docs and profile/tests/host_settings.rs. Verification on 29905a2: 965 top-level full-suite passes (0 failed/ignored), fmt, strict Clippy, focused shell regression. Initial independent native review of fe32a8f..c1170bb had no actionable findings; the follow-up review covering the fixture relocation and timing repair is pending (previously blocked by macOS Keychain authorization, now unblocked via the aigateway profile).

This branch now serves as the base for the recreated #252 follow-ups and feature integrations; see PRs 305-308 for the per-issue drafts. Do not merge.

@acoliver acoliver changed the title branch4 shared-repair tracking: restored feature completion after account suspension branch4 shared-repair tracking (was PR 296): #286 profile ownership Sep 22, 2026
@acoliver

Copy link
Copy Markdown
Contributor Author

Independent native follow-up review of fe32a8fb..29905a23 (gpt-6-sol high reasoning, session b4-286-solreview-20260922): ACCEPTED, no new findings.

Verified in the report (evalwork/results/pr-completion-20260920/issue286-review/report.md, rerun logs reviewer-*.log in the same directory):

  • Timing repair: omitted timeout fails with the exact 1000 ms diagnostic, 3 s budget permits a 2 s command, 30 s request under a 3 s max fails with the exact 3000 ms diagnostic, invalid inputs still rejected, and the unlimited-profile ceiling permits a 4 s command under a 5 s explicit budget with its completion marker (src/tools/tests.rs:879-914). The removed <8 s outer bound measured shared-lock queue wait, not the runner budget (src/process.rs:233,258).
  • No weakened assertions, skips, raised limits, runtime edits, shims or unrelated changes in the range; the fixture move is a byte-identical rename with three include-path updates, and the compatibility inventory still requires 73 entries (independently reran: 9 passed).
  • Exact-head gate records (repaired-focused/fmt/clippy/workspace exits 0; 965 top-level passes) match the worker logs; reviewer independently reran the focused regression (1 passed), compatibility target, fmt, and strict clippy at this head. The full workspace suite was not rerun by the reviewer; its result is verified against the worker logs, stated explicitly.
  • The retained preliminary/pre-fixture-move runs stay labeled non-acceptance; post-review git status clean.

The timing repair and fixture relocation are accepted on the repaired head. PR stays draft pending per-issue remaining work tracked in PRs 305-308.

@acoliver

acoliver commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

The reconciled current-main residual deliverable is now #319, exact 3d374424a89429c4932d3390ef1ef4d2ca6002c4. It excludes superseded Codex implementation now in merged #309, retains genuine non-Codex host policy and the salvaged unique #304/#306 test witnesses, and preserves this original branch/head/scope evidence.

Closing this tracking/older delivery in favor of the scoped replacement avoids a force rewrite or a second stale stack. #319 remains draft: independent integration verification, exact final packaging and fresh CI are still active; its retained MSRV deadline failure is disclosed. This closure is consolidation, not a claim of merge readiness.

@acoliver acoliver closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant