chore(deps): termlens 0.11, the stability candidate - #106
Merged
Merged
Conversation
From 0.11 no promised termlens item changes incompatibly before its 1.0, so this requirement should hold for a while. The one breaking change simplifies the invariant this suite rests on: `Screen::unsupported()` returns a view and `unsupported_overflow()` folds into it, and the view compares equal to a slice only when the retained shapes match *and* nothing overflowed the bound. The pinned list and "the record is not truncated" become one assertion, and the `Vec<String>` helper that existed to make the comparison possible is gone. The vendored skill moves to the 0.11 copy (check-skill-version.sh). Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
termlens#340 moved it there so that `inspect prog > file` saves a screen `render` and `diff` read back. These assertions read stdout, so they were the ones that noticed — and they only run under `--ignored`, which is why a local `cargo test` and `just ci` were both green while CI was not. Each now asserts the split rather than working around it: the trailer on stderr, and stdout carrying no trailer line at all. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
termlens 0.11.0 is on crates.io. It is that project's stability candidate: from 0.11.0 no promised item changes incompatibly before its 1.0, so this requirement should hold for a while rather than needing a bump every few weeks.
The one breaking change lands here as a simplification.
Screen::unsupported()returns anUnsupportedview instead of&[Arc<str>], andunsupported_overflow()folds into it. The view compares equal to a slice only when the retained shapes match and nothing overflowed the retention bound — so the two assertions intests/emulation.rsbecome one, and it is now impossible to pass a truncated record that happens to start with the expected entry:The
fn unsupported(screen) -> Vec<String>helper existed only to make that comparison typecheck and is gone.Everything else is mechanical: the requirement, the lockfile (
termlens 0.10.1 → 0.11.0, nothing else moved) and the vendored skill copy, whichcheck-skill-version.shholds equal to the dependency.Verified locally:
cargo clippy --workspace --all-targets --all-features -D warningsclean,cargo test --workspace --all-features240 passed, 0 failed — the emulation invariant included, in all three rendering modes (text cells, kitty, sixel).check-skill-version.shgreen at 0.11.0.From crates.io, never a path dependency or
[patch.crates-io].