ci: termlens 0.11's two stale pins, and the check that missed them - #77
Merged
Merged
Conversation
The 0.11 bump moved the dev-dependency, the lockfile, the vendored skill and both `cli-version:` inputs, and left `PIN_TERMLENS` in pins.yml and CONTRIBUTING's own line at 0.10.1. Nothing would have caught that: the skill-version check compared the skill and the workflow pins with the dependency and nothing else, so the first report would have been Monday's pins watch comparing 0.10.1 with crates.io and filing a drift issue for a bump that had already happened. Both are corrected, and the check now covers every entry on CONTRIBUTING's must-touch list instead of the skill alone. `PIN_TERMLENS` is compared with `Cargo.lock` exactly rather than on major.minor, because an exact version is what the watch compares: a lockfile moved to a patch release with the pin left behind produces the same false drift report, and major.minor would not see it. CONTRIBUTING gains the `cli-version:` inputs it never listed, so the list a bump follows is the list CI enforces. Verified by mutating each value in a copy of the tree: a stale PIN_TERMLENS, a lockfile ahead of the pin, a stale CONTRIBUTING line, a bumped dependency with nothing else moved, and a deleted PIN_TERMLENS line each exit 1 with the error naming the file; the unmodified tree exits 0. `just ci` is green (165 tests, 0 failed; deny ok; research green once rustup's proxy precedes Homebrew's cargo on PATH). Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68.
What was wrong
The termlens 0.11 bump moved the dev-dependency,
Cargo.lock, the vendored skill and bothcli-version:inputs. It left two behind at 0.10.1:PIN_TERMLENSin.github/workflows/pins.ymltermlens(currently …) line — the first line of the checklist every termlens bump is supposed to followNothing would have caught either.
check-skill-version.shcompared the skill and the workflowcli-version:pins with the dependency and nothing else, so the first report would have been Monday 06:17 UTC: the weekly pins watch comparing0.10.1with crates.io's0.11.0and opening a drift issue for a bump that had already happened.What changed
PIN_TERMLENS→0.11.0, the CONTRIBUTING line →0.11, and the check extended to cover the whole must-touch list rather than the skill alone.PIN_TERMLENSis compared withCargo.lockexactly, not on major.minor like the rest. An exact version is what the watch compares againstmax_stable_version, so a lockfile moved to a patch release with the pin left behind produces the same false drift report, and a major.minor comparison would not see it.CONTRIBUTING also gains the
cli-version:inputs it never listed, so the list a bump follows is now the list CI enforces.Verification
Each value mutated in a copy of the tree; every one fails, the unmodified tree passes:
PIN_TERMLENSback to 0.10.1 (the bug this closes)PIN_TERMLENSline deletedjust cigreen: 165 tests passed / 0 failed across 56 suites,cargo denyadvisories/bans/licenses/sources ok, docs warning-free, and the research workspace green on the pinned nightly.After this, the termlens line is gone from Monday's report. The run will still open a drift issue, correctly, for
reconverge(pinned 0.5.0, crates.io 0.6.1) andlaunchbound(pinned 2.1.0, crates.io 2.2.1) — those four pins move together by hand and are out of scope here.