T8218: Updated workflows for pullrequest_target policy change#21
Merged
dmbaturin merged 1 commit intovyos:currentfrom Mar 1, 2026
Merged
T8218: Updated workflows for pullrequest_target policy change#21dmbaturin merged 1 commit intovyos:currentfrom
dmbaturin merged 1 commit intovyos:currentfrom
Conversation
|
👍 |
dmbaturin
approved these changes
Mar 1, 2026
Member
dmbaturin
left a comment
dmbaturin
left a comment
There was a problem hiding this comment.
If it's required for workflows to run properly, I have nothing against it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR updates pull_request_target workflows to comply with GitHub's recent policy change announced on November 7, 2025 Actions: pull_request_target and environment branch protections changes.
Background
GitHub updated how pull_request_target workflows are evaluated. Previously, these workflows were evaluated using the PR's target branch. Now, they are always evaluated using the repository's default branch (current). This means branch-filtered workflows will only trigger reliably if they exist and match on the default branch.
Changes
Updated the workflows to include all supported branches in their pull_request_target trigger:
Since pull_request_target workflows are now evaluated from the default branch, the workflow file must exist unchanged on the default branch. To support branch-specific triggering across all maintained branches (current, circinus, sagitta), the branch filters must explicitly list all branches or be removed entirely.
These changes ensure that:
Workflows trigger correctly for PRs targeting any of the three supported branches
The workflow files are evaluated from the current branch as per GitHub's new requirement
Note:
As these workflows doesn't have any branch-specific logic, no changes needed apart from this.
Types of changes
Related Task(s)
https://vyos.dev/T8218Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: