feat[venom]: loop invariant#4819
Draft
harkal wants to merge 9 commits intovyperlang:masterfrom
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
Author
|
@HodanPlodky this is my implementation I told you I will push. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4819 +/- ##
==========================================
+ Coverage 91.97% 91.99% +0.01%
==========================================
Files 187 188 +1
Lines 27241 27393 +152
Branches 4784 4828 +44
==========================================
+ Hits 25055 25199 +144
- Misses 1464 1467 +3
- Partials 722 727 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📊 Bytecode Size Changes (venom)
Full bytecode sizes
|
frederikgramkortegaard
pushed a commit
to frederikgramkortegaard/vyper
that referenced
this pull request
Mar 31, 2026
Don't create preheaders in LICM - skip loops without valid preheaders instead. This avoids CFG modification complexity that caused malformed phi operands when processing multiple loops with stale cached analyses. The approach now matches PR vyperlang#4819's simpler design: loops must already have a valid preheader (single outside predecessor whose only successor is the loop header) for LICM to apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture