fix[venom]: remove FloatAllocas pass#4888
Merged
harkal merged 3 commits intovyperlang:masterfrom Mar 22, 2026
Merged
Conversation
📊 Bytecode Size Changes (venom)
Full bytecode sizes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4888 +/- ##
==========================================
- Coverage 91.96% 91.95% -0.01%
==========================================
Files 187 186 -1
Lines 27225 27198 -27
Branches 4779 4775 -4
==========================================
- Hits 25037 25010 -27
Misses 1466 1466
Partials 722 722 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Remove the
FloatAllocaspass, which hoistedallocainstructions to the entry basic block. The pass was a workaround for the old codegen emitting allocas in non-dominating positions. The current venom codegen already emits allocas that dominate their uses, making the hoisting unnecessary.How I did it
vyper/venom/passes/float_allocas.pyFloatAllocasfrom all three optimization pipelines (O2, O3, Os)FloatAllocasrequired_predecessors entry fromMem2VarFloatAllocasinvocation inFunctionInlinerPassHow to verify it
Commit message
Description for the changelog
Remove the
FloatAllocaspass. Allocas no longer need to be hoisted to the entry block — the underlying SCCP issues that required this have been fixed.