fix: respect DateTimeKind in ToDateTimeOffset#335
Open
evanofficial wants to merge 1 commit intow-ahmad:mainfrom
Open
fix: respect DateTimeKind in ToDateTimeOffset#335evanofficial wants to merge 1 commit intow-ahmad:mainfrom
evanofficial wants to merge 1 commit intow-ahmad:mainfrom
Conversation
ToDateTimeOffset always used TimeZoneInfo.Local offset, which throws 0x80070057 when passed a DateTime with DateTimeKind.Utc. Now checks DateTimeKind and uses TimeSpan.Zero for UTC DateTimes. Fixes w-ahmad#330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DateTimeExtensions.ToDateTimeOffset()always usedTimeZoneInfo.Local.GetUtcOffset(), which throws0x80070057("The UTC Offset for Utc DateTime instances must be 0") when passed aDateTimewithDateTimeKind.Utc.The fix checks
dateTime.Kindand usesTimeSpan.Zerofor UTC DateTimes, preserving existing behavior forUnspecifiedandLocalkinds.Changes
DateTimeExtensions.cs— CheckDateTimeKind.Utcbefore selecting the offsetDateTimeExtensionsTests.cs— AddedToDateTimeOffset_FromUtcDateTime_UsesZeroOffsettestFixes #330