refactor: quality tail (complexity batch 8 + function/file length splits) - #737
Merged
Merged
Conversation
…tail-8 # Conflicts: # scripts/lib/qualityBaseline.json
…il-8 # Conflicts: # scripts/lib/qualityBaseline.json
# Conflicts: # scripts/lib/qualityBaseline.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined quality-ratchet tail: complexity batch 8, the two worker/sheet-metal/beam function-length splits, and the remaining file-length splits, all pure refactors with no behaviour change intended.
Complexity batch 8 (15 functions, all under 20)
normaliseAutoAnnotate25 (in the newdrawingAuto/layout),runAnimate25,paramsHandler24,solveAnalytical24,tryVec324,traceFromImage24 (+163-line finding),fitPlane24,whyDidThisFailTool24,inspectTool24,addVariableSweep24,validateConnectorManifest23,checkOrphanParts23,validateAssemblyWithMates23,suggestLimitFix23,buildEdgeFeatureRef23.Function-length splits
worker.ts: the 231-line arrow and its 226-line async callback split by message kind; worker protocol byte-identical (new characterisation suite mocks the OCCT module).lowerSheetMetalBend161 lines;runBeamMode161 lines + complexity 21.File-length splits
proxy.ts1024 andplanPhases.ts942 into focused sibling modules; async producers extracted with explicit receiver params soShape.prototypeown-property layout is untouched (MCP drift sentinel green).sketch.ts883 →sketchReflect/sketchTangency;occtBackend.ts844 →backendInit/backendMesh; public names re-exported so all import paths keep working.emittedCodesAreCatalogued.test.ts.Baseline 56 → 31 findings: complexity 45 → 29, file 5 → 1, function 6 → 1. The only remaining entries for a single file are
src/modeling/api.ts(createApi654 lines + 973-line file), which is slice 8 territory. Nothing added, cycle baseline unchanged. Verification for the combined tree:npm run typecheck,npx eslinton all touched files,npm run test:ratchet,npm run qc:lint,npm run qc:build, plus each agent's targeted suites (worker protocol, proxy/reconstruct, sketch/occtBackend, sheet metal, beam mode, and the batch-8 module tests). CI runs the full suite.