refactor: quality tail finale — baseline cleared to zero - #738
Merged
Merged
Conversation
…tail-9 # Conflicts: # scripts/lib/qualityBaseline.json
…tail-9 # Conflicts: # scripts/lib/qualityBaseline.json
…tail-9 # Conflicts: # scripts/lib/qualityBaseline.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final quality-ratchet tail: every remaining baseline finding is cleared, so
scripts/lib/qualityBaseline.jsonis now empty (0 findings).Complexity batch 9 — the last 29 functions, all under 20
imageDimensions,parseTopoRef,buildNurbsFace,classifyHoleFace,buildMaterial(exportGlb),lowerCutout,getMassPropertiesTool,isVariableSweepMetadata,isCurve3DMetadata,buildNode(meshBvh),findPartHost,measureBearingCoplanarity,buildReferenceImageFeatureSpec,bridgeCurves,formatAst,getWire,runFeaTool,fetchPartTool,addPatternFeatureTool,projectionSymbol,computeProjectedUVs,expandCertificatePoses,resolveBendAxis,verifyAnimation, thePricingTiersarrow,exportPartTool,exportModelTool,drawingToCadTool,renderHuman.api.tssplitcreateApi654 → 22 effective lines,api.ts973 → 232, via namespace modules (apiShapeMethods,apiParamMethods,apiCaptureMethods,apiSurfaceMethods,apiPartsLib,apiModuleNamespaces,apiSupport). Public surface pinned byte-identical: sameObject.keysat every level, 197 template literals and 30 error codes as identical multisets, per-symbol AST verbatim check, listApi/skill-globals drift sentinels green. The kinematic imports stay inapi.tson purpose — removing the allowlist entries is slice 8.Baseline: 31 → 0 findings; cycle baseline unchanged (7). Three characterisation tests added where coverage was missing (
getWire,runFeaTool,resolveBendAxis,renderHuman).Verification for the combined tree:
npm run typecheck,npx eslinton all touched files,npm run test:ratchet(13/13 with an empty baseline),npm run qc:lint,npm run qc:build, plus each agent's targeted suites (~600 tests across the 29 modules and the api/drift/site checks). CI runs the full suite.Next per the spec: with the baseline empty, lower the thresholds to complexity 15 / function 100 lines and repeat once.