refactor: lowered-threshold pass, wave 1 (30 complexity findings) - #740
Merged
Merged
Conversation
# Conflicts: # scripts/lib/qualityBaseline.json
# Conflicts: # scripts/lib/qualityBaseline.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First wave of the lowered-threshold pass (complexity 15 / 100 function lines, #739).
30 complexity findings cleared (all were at exactly 20 except where noted):
useFaceSelectionarrow,AgentComposer,jointPrimitiveToSnapshot,addRecordKeys,voxelize,checkClearance,reviewCertifiedJointLoads,reviewMechanicalTransmission,checkRequiredSupport,preflightSupportedServoRevolute,materialBlock,urdfSerialize,planDrag,processRecord,spline,parseJpeg,emitSceneBackendFanout,normalizeFdmSettings,recordMate,loftSketchSections,lowerFillet,findEdgeByName, theapiShapeMethodsarrow,inspectContinuity,flattenPattern,collectHolePositionDimensions,recentreHoleOnFace,segmentMesh,fitCylinder,resolveTopoRefTool— plus 8 function-length findings that the same splits removed (e.g.AgentComposer,flattenPattern112→17 lines).Baseline 261 → 223 findings (155 complexity, 68 function-length); cycles unchanged at 7. Four characterisation tests added where coverage was missing (
useFaceSelection,processRecord,recordMate,findEdgeByName).Verification: typecheck, eslint on all touched files, ratchet suites 13/13,
qc:lint,qc:build, plus each group's targeted suites (~450 tests across the 30 modules). CI runs the full suite.