Conversation
Issue #610 notes that there is no defined considerations for fragment identifiers with AS2. This erratum notes the absence, and suggests an adjustment to default to JSON-LD treatment.
5 tasks
snarfed
approved these changes
Feb 16, 2026
Member
snarfed
left a comment
There was a problem hiding this comment.
Looks good.
The one thing I immediately thought of is resolution failure, eg when fetching the URL (without fragment) returns 404, or doesn't return AS2, or returns an AS2 object that doesn't contain an element with the fragment id. (These are all common on the fediverse right now.) Some examples in w3c/activitypub#367 (comment) and further down the thread.
I expect this doesn't change our resolution failure logic at all, so we probably don't need to say anything explicitly, but I figured I'd check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #610 notes that there is no defined considerations for fragment identifiers with AS2. This erratum notes the absence, and suggests an adjustment to default to JSON-LD treatment.