Add frame counters#125
Merged
Merged
Conversation
youennf
reviewed
Apr 9, 2026
jan-ivar
reviewed
Apr 9, 2026
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
youennf
approved these changes
Apr 9, 2026
youennf
reviewed
Apr 16, 2026
jan-ivar
reviewed
Apr 16, 2026
jan-ivar
approved these changes
Apr 16, 2026
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: youennf <youennf@users.noreply.github.com>
youennf
reviewed
Apr 16, 2026
youennf
reviewed
Apr 16, 2026
Contributor
|
We should probably update that note. Maybe: |
youennf
reviewed
Apr 16, 2026
| specific situations. In this case, `[[numDiscardedFrames]]` MUST be incremented | ||
| accordingly. In all cases, frames that are not dropped must be made available | ||
| to the {{ReadableStream}} in the order in which they arrive to the | ||
| {{MediaStreamTrackProcessor}}. |
Contributor
There was a problem hiding this comment.
We could remove or reduce this sentence given this is already stated. I filed #126.
github-actions Bot
added a commit
that referenced
this pull request
Apr 16, 2026
SHA: cd21bb6 Reason: push, by guidou Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff