Skip to content

Add dark mode support for the Unicode codepoint template #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xfq wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Add dark mode support for the Unicode codepoint template #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@
--outdated-shadow: red;

--editedrec-bg: darkorange;

--uname: brown;
}

/******************************************************************************/
Expand Down Expand Up @@ -1382,7 +1384,7 @@ Possible extra rowspan handling
font-family: Arial, monospace;
font-size: 0.75em;
letter-spacing: 0.03em;
color: brown;
color: var(--uname);
}

/** Outdated warning **********************************************************/
Expand Down
2 changes: 2 additions & 0 deletions src/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,6 @@ img { background: white; }
--outdated-shadow: red;

--editedrec-bg: darkorange;

--uname: rgb(215 99 99);

@deniak deniak Mar 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--uname: rgb(215 99 99);
--uname: rgb(215, 99, 99);

@deniak deniak Mar 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xfq how did you come up with that color?

I checked the contract ratio and it doesn't pass WCAG AAA.

rgb(215, 140, 140) seems to work .better

@xfq xfq Mar 25, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I selected it manually, because I think the contrast is good enough for me and AAA requirements are not recommended to be included in legislation by default, but I'm OK with colour you picked as well.

As for the syntax, since the recommended space-separated notation is now supported by all major browsers, I wonder if we can adopt it?

}