Fix mismatched prCredUnsigned.json description compared to data from ecdsa-sd-2023/prc/#103
Open
scouttyg wants to merge 1 commit into
Open
Fix mismatched prCredUnsigned.json description compared to data from ecdsa-sd-2023/prc/#103scouttyg wants to merge 1 commit into
scouttyg wants to merge 1 commit into
Conversation
|
iherman marked as non substantive for IPR from ash-nazg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In e11e92c / #89 , some test vectors were added to the repo/document, but then after some discussion within the PR the
descriptionfield within some of the json files was reworked to be different than originally written, which led to drift from the base https://github.com/w3c/vc-di-ecdsa/blob/main/TestVectors/prCredUnsigned.json#L15 file, and potential issues.In a nutshell, the files within
prc/were changed from:to:
But the base
prCredUnsigned.jsonremained"Government of Utopia Permanent Resident Card."Ideally, there could be some small Github workflow scripts that can sanity-check the fields and values from the base json files with their broken down parts, but for now this should align the base value at least with the values now in
prc/json files.Preview | Diff