Add a jose-cose section to implementer info.#113
Conversation
Data and format are from w3c/vc-jose-cose-test-suite@a37a75e
davidlehn
left a comment
There was a problem hiding this comment.
Approving to keep things moving.
- These implementation files really need optional URLs for both the vendor and implementation. Maybe other metadata too.
- It's not clear what "Independent" means. Is that a company, project, meta name, or something else?
- I'm guessing the diff failure is due to not handling new files and can be handled later.
Thanks!
Indeed. I intend to come back to #26 soon.
Pretty sure that's @decentralgabe judging by the commit log in https://github.com/w3c/vc-jose-cose-test-suite/ but...yeah...it should be changed to something understandable.
Yeah. It expects both files to exist. Something else to fix...eventually. |
|
@decentralgabe I've used your GitHub user name as the name of the implementation (and the "vendor"). Let me know if that's an issue for you via a PR. 😄 Also, it may be best to extract that implementation as a git submodule (or similar), so that it's not maintained within the test repository as it is currently: https://github.com/w3c/vc-jose-cose-test-suite/tree/main/implementations/independent Cheers! |
Data and format are from
w3c/vc-jose-cose-test-suite@a37a75e
Prepares for w3c/vc-jose-cose-test-suite#30