Repository navigation
Treat 429 like a 5xx in the session request algorithm - #270
Open
MarshallOfSound wants to merge 1 commit into
Open
MarshallOfSound wants to merge 1 commit into
MarshallOfSound wants to merge 1 commit into
Conversation
A 429 from the registration or refresh endpoint currently sits with network errors and 407: the user agent returns without terminating the session, and the Secure-Session-Skipped guidance implies "unreachable". A 429 is a server response asking the client to slow down, so it fits better with the 5xx branch: keep the session, surface it as server_error, and let the user agent apply its refresh backoff. This moves 429 out of the network-error step, excludes it from the generic 4xx termination step, and adds it to the 5xx/backoff step and the server_error token description.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 429 from the registration or refresh endpoint currently sits with network errors and 407 in the "send a request" algorithm, so the user agent keeps the session but the failure reads as "unreachable". A 429 is the server asking the client to slow down, so it fits better alongside 5xx: keep the session, report it as
server_error, and let the user agent apply its refresh backoff.This change:
server_errordescription forSecure-Session-Skipped.Chromium change doing the same: https://chromium-review.googlesource.com/c/chromium/src/+/8613310