Draft: Port W3D Viewer from MFC to Qt 6 - #158
Draft
caseychaos1212 wants to merge 2 commits into
Draft
Conversation
Collaborator
|
There is a lot going on in this PR (which I realise is still WIP), I would prefer the engine improvements to be PR'd separately as well as adding unit testing, one for each improvement (mempool, audio engine, chunk format handling) as they can be reviewed and merged separately and have the addition of the new QT port of W3DView follow that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft introduces
W3DViewQt, a Qt 6 Widgets port of the legacy MFC W3D Viewer.The goal is feature parity with the supported MFC application while moving all editable layouts into Qt Designer forms. The port currently includes 28 checked-in
.uifiles, including the main window and all custom dialogs.This is intentionally a draft. Additional native parity testing and several export edge cases remain before it should be merged.
Implemented
windeployqtQt and audio requirements
d3dx9_43.dllSupporting engine changes
Validation
Tested with Visual Studio 2022 x64 in Release configuration.
uicvalidationRemaining work
Review notes
Because this remains a draft, review is currently most useful around architecture, Qt ownership, shared-engine API changes, and any missing MFC workflows. Additional fixes and validation commits will be added to this branch before marking the PR ready for review. Much of this code was written by Codex 5.4-5.6 I've been testing assets from renegade as I've gone. I'm not familiar with every feature for the original w3d viewer so I haven't been able to test every workflow.