Use std::filesystem in BinkMovie/SubTitleManagerClass - #182
Open
madebr wants to merge 1 commit into
Open
Conversation
madebr
marked this pull request as draft
August 28, 2026 16:43
madebr
force-pushed
the
c++-fs-bink-movie
branch
from
August 29, 2026 15:16
66b9dd7 to
1fadd7d
Compare
madebr
marked this pull request as ready for review
August 29, 2026 15:17
madebr
commented
Aug 29, 2026
| _splitpath(filename, nullptr, nullptr, fname, nullptr); | ||
| bool loaded = instance->Load_Sub_Titles(fname, subtitlefilename); | ||
| std::filesystem::path fs_filename = filename; | ||
| auto fname = fs_filename.stem().generic_string(); |
Author
There was a problem hiding this comment.
This pr is ready for review. I used .filename() instead of .stem() before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.