Skip to content

Fix SControl socket portability on Linux - #185

Open
caseychaos1212 wants to merge 2 commits into
w3dhub:mainfrom
caseychaos1212:fix/linux-scontrol-sockets
Open

Fix SControl socket portability on Linux#185
caseychaos1212 wants to merge 2 commits into
w3dhub:mainfrom
caseychaos1212:fix/linux-scontrol-sockets

Conversation

@caseychaos1212

Copy link
Copy Markdown
Collaborator

Summary

  • replace Windows-only socket address types in SControl
  • use platform-appropriate socket length types
  • replace Sleep(0) with std::this_thread::yield()
  • use the existing cross-platform socket error abstraction
  • add scontrol to the Linux CI target list

Verification

  • built scontrol with RelWithDebInfo on Linux
  • built scontrol with Debug on Linux
  • built the expanded Linux CI baseline successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant