Add localization catalog, helpers and en/zh Localizable.strings for app & widget#1
Open
Add localization catalog, helpers and en/zh Localizable.strings for app & widget#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
zh-Hansprovided as a Simplified Chinese translation.LocalizedStringResource/String(localized:)-style access) and to add further keys by domain.Description
LocalizationCataloginSources/CodexBarCore/LocalizationCatalog.swiftwhich defines namespaced keys and English fallbacks (e.g.menu.settings,preferences.general.title,alert.login.codex_missing_cli.title,widget.empty.open_app).AppStrings(Sources/CodexBar/AppStrings.swift) andWidgetStrings(Sources/CodexBarWidget/WidgetStrings.swift) that exposestring(_:),text(_:),formatted(_:)andresource(_:)convenience methods for app and widget usage.Localizable.stringsunderSources/CodexBar/Resources/{en,zh-Hans}.lprojand equivalent files underSources/CodexBarWidget/Resources/, and updatePackage.swiftto setdefaultLocalization: "en"and to process widget resources (resources: [.process("Resources")]) so SwiftPM will include them.Sources/CodexBar/PreferencesDisplayPane.swift,Sources/CodexBar/StatusItemController+Actions.swift(Codex login alerts), andSources/CodexBarWidget/*(empty states, metrics, and intent titles/descriptions) to the new helpers, and addTests/CodexBarTests/LocalizationCatalogTests.swiftto assert English baseline resolution.Testing
git diff --checkwas run and passed with no whitespace errors.pnpm checkwas attempted but failed due to an HTTP 403 when the environment tried to download tooling (SwiftFormat), so lint tooling did not complete.swiftformat Sources Testsandswiftlint --strictwere not executed successfully in this environment because those binaries are not available.swift buildand./Scripts/compile_and_run.shwere attempted but failed because SwiftPM could not fetch external dependencies in this environment (HTTP 403), so an end-to-end build/test run could not be completed here.Codex Task