Add L10n helper and merge PR #3 localization into core resources#4
Open
waffensam wants to merge 2 commits intocodex/add-localized-string-resources-for-codexbarfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
L10n.tr(Sources/CodexBarCore/Localization/L10n.swift) and includeResourcesfor the core target inPackage.swiftso localized strings can be loaded fromCodexBarCore.Localizable.stringsunderSources/CodexBarCore/Resources/en.lproj/Localizable.stringscontaining keys required by the merged changes.L10n.tr(...)across About, Menu, Keychain prompt, Preferences (General/Advanced/About/Debug/View), StatusItem login alerts, and other impacted files to centralize copy and avoid further conflicts.Testing
git diff --check) which reported no whitespace/merge issues.pnpm check(lint script) and it failed due to the environment attempting to download SwiftFormat from GitHub and receiving HTTP 403, so automated linting could not complete.swiftformat/swiftlintandswift test, but these commands were unavailable or failed because the environment cannot fetch SwiftPM/GitHub dependencies (network 403), so full build/test and the./Scripts/compile_and_run.shpackaging run could not be completed here.Codex Task