Ci/desktop release followups#58
Closed
lazToum wants to merge 2 commits into
Closed
Conversation
…4; add windows-arm The draft-release upload step was failing with "Resource not accessible by integration" — the workflow had no permissions block, so the default GITHUB_TOKEN was read-only. Also moves the Linux build image off the soon-retired ubuntu-22.04 runner, adds a windows-11-arm matrix entry to ship native Windows ARM64 builds, and refreshes Cargo.lock which had drifted to 0.4.2 since the 0.4.4 version bump.
…f Node 20 The ubuntu aarch64 job has failed on every release since v0.4.0 with "pkg-config has not been configured to support cross-compilation" — gobject-sys/glib-sys can't link the host-arch (amd64) GTK/WebKit dev libs into an aarch64 binary, and no sysroot was ever configured. Switch to the native ubuntu-24.04-arm hosted runner instead (mirrors the windows-11-arm approach, which already builds successfully) — this removes the entire cross-compilation toolchain/sysroot problem. Also bump actions/checkout@v4 -> v6 and actions/upload-artifact@v4 -> v7: both still run on Node.js 20, which GitHub Actions starts forcing to Node 24 on 2026-06-16 and removes entirely on 2026-09-16. v6/v7 declare node24 and have no input/output changes affecting this workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-24.04-arminstead of cross-compilingon
ubuntu-24.04— the cross-compile job has failed on every release sincev0.4.0 with a
pkg-config/gobject-syscross-compilation error (host-archGTK/WebKit dev libs can't be linked into an aarch64 binary without a
configured sysroot). Mirrors the
windows-11-armnative-runner approach,which already builds successfully.
actions/checkout@v4->@v6andactions/upload-artifact@v4->@v7to get off the deprecated Node.js 20 runtime (GitHub forces Node 24 on
2026-06-16, removes Node 20 entirely on 2026-09-16). Both new majors declare
using: node24with no breaking changes for this workflow's usage.desktop-release.ymlfixes (permissions, Ubuntu 24.04,windows-11-arm, Cargo.lock refresh) cherry-picked over from fix(ci): repair desktop-release upload + bump Ubuntu + add Windows ARM64 #57, which had
landed on
maininstead ofdevand needs to be here too.Test plan
workflow_dispatchrun of Desktop Release on thisbranch and confirm all five matrix jobs build (ubuntu x86_64,
ubuntu-24.04-arm, windows x64, windows-11-arm, macos universal)
ubuntu-24.04-armis enabled as a hosted-runner label for thisorg/plan (new label — if not, the job fails to schedule rather than
fails to build)
from the job logs