feat: gmo gemの更新

[Roy-Mao]

gmo gemの最新化
5.0.4 → 5.0.9

[gemini-code-assist]

Code Review

This pull request implements support for 3D Secure 2.0 and GANB (Aozora Bank) virtual accounts, adds nkf as a dependency for encoding management, and updates the core API to support JSON responses. The review feedback identifies several critical improvements for the response processing logic, including the need to handle nil results during JSON parsing and the importance of restricting encoding conversions and URL reassembly to non-JSON paths to prevent data corruption or runtime errors. Additionally, using more robust JSON generation methods in the HTTP service layer is recommended to ensure consistency and reliability.

[gemini-code-assist]

The JSON parsing logic can result in response being nil if the API returns an empty array [] or null. This will cause a NoMethodError in subsequent lines (e.g., line 54 or 59) when attempting to access keys on a nil object. It is safer to ensure response defaults to an empty hash.

          parsed_result = ::JSON.parse(result.body)
          response = (parsed_result.is_a?(Array) ? parsed_result[0] : parsed_result) || {}

[gemini-code-assist]

Applying NKF.nkf with the -S (Shift_JIS) flag to all response values is problematic for JSON responses. First, NKF.nkf expects a string and will raise a TypeError if the JSON contains non-string values (like integers for amounts). Second, forcing Shift_JIS interpretation on a JSON response that is already UTF-8 (as indicated by the charset=UTF-8 header in the VCR cassettes) will lead to data corruption. Encoding conversion should be restricted to non-JSON responses which use Shift_JIS/Windows-31J.

        unless /\.json\Z/ =~ path
          response = Hash[response.map { |k,v| [k, NKF.nkf('-S -w', v)] }]
        end
        body = response

[gemini-code-assist]

This logic for reassembling RedirectUrl is brittle as it relies on the exact order of keys in the hash and only handles the t parameter. More importantly, this transformation is only necessary for responses parsed from query strings where the URL was incorrectly split by the & delimiter; it should not be applied to JSON responses where the URL is already correctly parsed as a single string. Applying it to JSON might incorrectly modify the URL if a top-level t key happens to exist in the response.

        if path !~ /\.json\Z/ && response['RedirectUrl'] && response['t'] && response.keys.index('RedirectUrl') + 1 == response.keys.index('t')
          response['RedirectUrl'] = "#{response['RedirectUrl']}&t=#{response['t']}"
          response.delete('t')
        end

[gemini-code-assist]

Using args.to_json relies on the json library monkey-patching Hash. It is safer and more consistent with the project's dependencies to use ::JSON.generate(args) or MultiJson.dump(args) to ensure the method is available.

                h.post(path, ::JSON.generate(args), headers)