Repository navigation
Make clipboard checks verify exact content and fallback behavior - #4
Open
wangkeyu-u wants to merge 1 commit into
Open
wangkeyu-u wants to merge 1 commit into
wangkeyu-u wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix false-positive clipboard checks without changing the gallery implementation or dataset. The old single-card smoke test passed after both clipboard methods failed and the browser fell back to manual copying; the multi-card test accepted any three-line text.
preview-data.json.Independent validation: deterministic build with unchanged
preview-gallery.html, functional checks over 230 cards, and all four copy branches passed. Two browser-memory mutations now exit nonzero: a no-opcopyPromptand incorrect three-line selected-card output. The auditor reproduced both original false-positive cases before the test changes.GitHub Actions passed on Linux/Node.js 22 for head
6a00d1a, covering locked dependency installation, browser setup, deterministic build, functional checks and all four copy branches.