Repository navigation
test: use fast TEST_KDF vault in beforeEach to avoid Argon2id timeouts in CI - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-create vault with TEST_KDF (memory=1024, iterations=1) in beforeEach for get.test.ts and add.test.ts, so addCommand reuses fast KDF params instead of creating a new vault with production-grade DEFAULT_KDF_PARAMS (memory=65536, iterations=3). This eliminates heavy Argon2id operations in hooks/tests that were causing 30s timeouts in CI coverage runs. Test 1 in add.test.ts (which exercises vault creation) explicitly removes the pre-created vault and has an extended 60s timeout.