BadSSIL: Avoid using C-style inits to broaden GLSL compatability.#2
Open
OdieHerpaderp wants to merge 1 commit intowareya:mainfrom
Open
BadSSIL: Avoid using C-style inits to broaden GLSL compatability.#2OdieHerpaderp wants to merge 1 commit intowareya:mainfrom
OdieHerpaderp wants to merge 1 commit intowareya:mainfrom
Conversation
This prevents the shader from breaking on lower GLSL versions.
Capostrophic
reviewed
Jun 2, 2025
| float e_v = dot(e.rgb, vec3(0.333)) * e.a; | ||
|
|
||
| float eles[5] = {a_v, b_v, c_v, d_v, e_v}; | ||
| float eles[5]; |
There was a problem hiding this comment.
float eles[5] = float[](a_v, b_v, c_v, d_v, e_v); is the idiomatic way to do this supported by 1.20 spec.
Also, use spaces for formatting. 😿
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the shader from breaking on lower GLSL versions.