Skip to content

fix(hw-gate): isolate each Fable session's evidence dir; keep the seat's raw output on a no-decision #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaden-Schutt merged 1 commit into from
Sep 4, 2026
Merged

fix(hw-gate): isolate each Fable session's evidence dir; keep the seat's raw output on a no-decision #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/hw-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,11 @@ jobs:
GH_TOKEN: ${{ steps.token.outputs.token || github.token }}
run: |
set -euo pipefail
# The runner reuses its workspace: without the rm, Fable inherits the
# previous PR's evidence files and home (run 33866758629 on #702
# carried #700's fable-summary.md and #686's route outputs) and can
# cite them as its own. Every session starts empty.
rm -rf fable-evidence fable-home
mkdir -p fable-evidence fable-home
exec 9>/home/kaden/actions-runner/_cache/hw-gate-gpu.lock
flock --exclusive --timeout 3600 9
Expand Down
8 changes: 8 additions & 0 deletions scripts/hw-gate/review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,6 +1288,10 @@ def _run_decide(args) -> int:
decision = None
fable_unavailable = False
fable_error_reason: str | None = None
# What the seat actually said/emitted when it did not produce a decision.
# Run 33866758629 (#702) ended "no JSON object in assistant text" after 10 s
# and the artifact carried nothing to diagnose it with.
fable_raw: dict | None = None
investigation: list = []
unproven: list = []
if investigate:
Expand Down Expand Up @@ -1346,6 +1350,8 @@ def _run_decide(args) -> int:
fable_unavailable = True
fable_error_reason = "omp decide: no JSON object in assistant text"
sys.stderr.write(f"fable omp failed: {fable_error_reason}\n")
sys.stderr.write(f"fable assistant text (tail): {(last_text or '')[-2000:]!r}\n")
fable_raw = {"assistant_text_tail": (last_text or "")[-4000:], "stderr_tail": stderr_text[-4000:]}
investigation = []
unproven = []
decision = None
Expand Down Expand Up @@ -1625,6 +1631,8 @@ def _has_hold(r: str) -> bool:
"investigation": investigation,
"unproven": unproven,
"evidence_dir": evidence_dir_val,
"fable_error": fable_error_reason,
"fable_raw": fable_raw,
}
try:
Path(args.out).parent.mkdir(parents=True, exist_ok=True)
Expand Down
Loading