Skip to content

fix(serve_harness): the per-run home wins over an inherited HIPFIRE_HOME #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaden-Schutt merged 1 commit into from
Sep 4, 2026
Merged

fix(serve_harness): the per-run home wins over an inherited HIPFIRE_HOME #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/serve_harness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,7 +1951,14 @@ def spawn_serve(cfg, home, log):
# Honor a caller-provided per-GPU daemon binary (a renamed copy → distinct
# process comm → the CLI's reapOrphans `pkill -x <name>` stays scoped to THIS
# instance). HIPFIRE_DAEMON_NAME/ID pass through from os.environ untouched.
env = dict(os.environ, HOME=home, HIP_VISIBLE_DEVICES=os.environ.get("HIP_VISIBLE_DEVICES","0"),
# The isolated home MUST be what the daemon resolves. ConfigPaths::discover
# prefers HIPFIRE_HOME over $HOME/.hipfire, so an inherited HIPFIRE_HOME
# (hw-gate exports one per lane) silently replaced this run's config.toml
# with the parent's: [speculation] mtp="off" never reached the daemon, the
# schema default `auto` auto-attached a sibling .mtp head, and the two gate
# lanes diverged on host state (hw-gate run 33900101473, #691).
env = dict(os.environ, HOME=home, HIPFIRE_HOME=os.path.join(home, ".hipfire"),
HIP_VISIBLE_DEVICES=os.environ.get("HIP_VISIBLE_DEVICES","0"),
HIPFIRE_DAEMON_BIN=os.environ.get(
"HIPFIRE_DAEMON_BIN",
os.path.join(REPO, "target", "release", "daemon" + (".exe" if os.name == "nt" else ""))),
Expand Down
Loading