fix(probe): find daemon binary with .exe on Windows - #738
Merged
Kaden-Schutt merged 1 commit intoSep 9, 2026
Conversation
find_daemon_binary() probes target/release/daemon without the .exe extension, so coherence_probe always fails with 'daemon binary not found' on Windows. Add the .exe candidates first (release + debug), keeping the extensionless ones for Unix. Signed-off-by: kolja <kolja@local>
Collaborator
|
Merged into beta at d2e2ee0, preserving the original commit and adding 7240773 to follow the CLI platform policy: Unix ignores stale .exe files; Windows prefers .exe with the existing bare-name fallback. Independent code review approved. Extracted real-function filesystem smoke passed 5 Unix and 6 simulated-Windows cases. Actual Windows process launch was not exercised here; the PR author supplied the original Windows discovery receipt. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
find_daemon_binary()probestarget/release/daemonandtarget/debug/daemonwithout the.exeextension, socoherence_probealways exits with "daemon binary not found" on Windows.Fix
Add the
.execandidates first (release + debug), keeping the extensionless ones for Unix. Two-line change, no behavior change on non-Windows (the.exepaths simply don't exist there andexists()falls through).Validation
Verified locally on Windows 11: probe now locates
target/release/daemon.exeand proceeds past binary discovery.HW-gate routes
scripts/serve_harness.py: generation/state-lifecycle changed? Noscripts/redline_daemon_harness.py: kernel/dispatch change? No (example tooling only)