Repository navigation
Sync remaining Windows fixes from Zeron #313 - #14
Merged
Merged
Conversation
…breaks - AcpHarness::installed() now validates `executable`/env overrides the same way resolve_launch does, so a missing override is not advertised as an installed agent whose model discovery and launch both fail. The static-catalog fallback test now uses an executable that exists but cannot speak ACP (the probe-failure case it was written for); a new test covers the missing-override case as not-installed + NotInstalled. - executable.rs: the two PATHEXT-casing tests wrote one case to disk and looked up another, which only resolves on case-insensitive filesystems. Match the on-disk name so they pass on Linux too. - codex_login_resolution: the npm .cmd shim test depends on PATHEXT discovery and is now cfg(windows). - claude_availability: the not-installed probe skips on machines with a system-wide /usr/local/bin or /opt/homebrew/bin claude, like its sibling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the remaining Windows fixes from zeronsh#313: precise animation timing, backdrop updates after settings clicks, and link popups that allow clicks to reach other controls. Also validates ACP executable overrides and corrects case-sensitive discovery tests.
Preserves Kratos Mimir integration, renderer pins, and its cross-platform login test. Unit tests retain GPUI's deterministic timer because the native timer's worker thread is incompatible with its test scheduler. Adds Unix agent-discovery coverage to CI.
Validation: formatting and diff checks pass; 179 local harness tests, 974 Windows UI tests, and all 5 native desktop link tests pass. CI and the release application build were still pending at merge time.