feat(types): Add LimitsConfig field to ComponentProperties #670
feat(types): Add LimitsConfig field to ComponentProperties #670Aditya1404Sal wants to merge 2 commits intowasmCloud:mainfrom
Conversation
Aditya1404Sal
changed the title
brooksmtownsend
left a comment
brooksmtownsend
left a comment
There was a problem hiding this comment.
Only a spelling nit! LGTM once @thomastaylor312 's comments are addressed.
crates/wadm-types/src/lib.rs
Outdated
| /// these values at runtime using `wasmcloud:secrets/store`. | ||
| #[serde(default, skip_serializing_if = "Vec::is_empty")] | ||
| pub secrets: Vec<SecretProperty>, | ||
| /// This Config holds the componet's metadata properties like memory limits and execution time limits |
There was a problem hiding this comment.
| /// This Config holds the componet's metadata properties like memory limits and execution time limits | |
| /// This Config holds the component's metadata properties like memory limits and execution time limits |
Got it—I'll have those resolved ASAP 🫡 |
…ular per-component resource control Signed-off-by: Aditya <aditya.salunkh919@gmail.com>
Aditya1404Sal
force-pushed
the
meta_component_properties
branch
from
8c9ae26 to
6c50ea6
Compare
| id: option<string>, | ||
| config: list<config-property>, | ||
| secrets: list<secret-property>, | ||
| limits: list<limits-config>, |
There was a problem hiding this comment.
We should bump the version of the package and add a since annotation on these. @brooksmtownsend any preference on whether we do a minor bump or a patch bump? I think with wit, if you add something to a record it is a breaking change, right?
|
@thomastaylor312 Is it alright to proceed further with these considerations or keep a u64 type and specifically instruct users on a set unit like megabytes and milliseconds |
|
Sorry @Aditya1404Sal this fell through the cracks. I think human readable/parsable formats are great so go ahead with that |
- Modify LimitsConfig to wadm-types for uni-config scenarios only - Update ScaleComponent command to include limits field - Add compute_limits function in scaler/convert.rs using parse-size crate for validation - Support human-readable formats like 1GB, 512MB, 30s for manifest configuration~ Signed-off-by: Aditya <aditya.salunkh919@gmail.com>
3 participants
for granular per-component resource control
Feature or Problem
This PR aims to allow the
max_linear_memoryfield to be configurable by the wadm.yaml, which will ultimately be used for setting per component resource limits.Related Issues
Memory Limits Per Component
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification