fix(wadm-client): update model list topic to use 'get' instead of 'list'#711
Open
jtakakura wants to merge 2 commits intowasmCloud:mainfrom
Open
fix(wadm-client): update model list topic to use 'get' instead of 'list'#711jtakakura wants to merge 2 commits intowasmCloud:mainfrom
jtakakura wants to merge 2 commits intowasmCloud:mainfrom
Conversation
Signed-off-by: Junji Takakura <j.takakura@gmail.com>
jtakakura
force-pushed
the
fix/update-list_manifests
branch
from
51ea9e8 to
628eb67
Compare
brooksmtownsend
approved these changes
Aug 12, 2025
Member
brooksmtownsend
left a comment
brooksmtownsend
left a comment
There was a problem hiding this comment.
Hey @jtakakura ! Good work here, I think this looks solid 👍🏻 We can probably remove that function later
jtakakura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR addresses a deprecation warning by updating the wash app list command to use the recommended model.get subject instead of the deprecated model.list.
Related Issues
[BUG] wash uses model.list which gives a deprecation warning on wadm
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification