Skip to content

Add PackageName.qualify - #4

Closed
jingibus wants to merge 1 commit into
mainfrom
jingibus/2026-06-18/qwzunrlslkqr
Closed

Add PackageName.qualify#4
jingibus wants to merge 1 commit into
mainfrom
jingibus/2026-06-18/qwzunrlslkqr

Conversation

@jingibus

Copy link
Copy Markdown
Collaborator

No description provided.

@jingibus
jingibus requested a review from swankjesse June 18, 2026 17:32

@swankjesse swankjesse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t think local is actually a part of the WIT language, just a part of the examples?
https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md

I was under the impression that local packages are more like inline packages, and our processing code should promote them to be peers with the TopLevelPackage type. As a result, parsing a single directory of .wit files could produce a List<IoTopLevelWitPackage>

(But I’m not sure I’m reading the same docs as you, or if I’m reading 'em right!

@jingibus

Copy link
Copy Markdown
Collaborator Author

It's not part of the grammar, but it's implied that local is elided when translating to the fully qualified package name?

Maybe I need to check the reference implementation? This wonderfully friendly interaction left me with the definite impression that there's only one implementation, and so the spec might be incomplete by itself

@jingibus

jingibus commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Turns out my assumption was completely wrong here. There's no hierarchical relationship implied with the package a subpackage lives in: it's just a wholly distinct package defined within the context of another package

So this is entirely unnecessary

@jingibus jingibus closed this Jul 7, 2026
@jingibus
jingibus deleted the jingibus/2026-06-18/qwzunrlslkqr branch July 29, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants