Repository navigation
Fix web file pickers and settings links not opening - #62
Merged
Merged
Conversation
Browse relied on display:none inputs plus synthetic click(), which fails in some Chromium setups while drag-and-drop still works. Switch upload/import pickers to label-activated sr-only inputs, open the import dialog in the same user gesture (no rAF), and portal popover backdrops so they cannot stack above menu links and swallow clicks. Co-authored-by: Wassim Gharbi <wassgha@gmail.com>
wassgha
marked this pull request as ready for review
August 2, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the web-only report where browse never opens a file dialog (DnD still works), settings links do nothing, and Chrome shows no “popups blocked” indicator.
Root causes addressed:
display: noneinputs + syntheticinput.click(). That pattern fails in some Chromium setups; drag-and-drop still works. Upload / transcript import now use label-activatedsr-onlyinputs.input.click()torequestAnimationFrame, which drops the user gesture so Chrome never shows the dialog. The picker now opens in the same turn as the click.Test plan