WIP: Ndv postprocess module part1#129
Conversation
… still issues with projections
…processing module
There was a problem hiding this comment.
Your ini file contains absolute paths (/nas/homes/niels-1000010/GitHub). Use relative paths instead.
| return fig, ax | ||
|
|
||
| self._mask.plot = plot | ||
| self._mask.file_path = mask |
There was a problem hiding this comment.
The file_path argument for RasterFile-objects is a realy good addition. However, in the class RasterFile it is only stored when rp=None and file_path.suffix=.sdat. Can you adjust the RasterFile-object attributes?
| "os.chdir(\"../..\")\n", | ||
| "\n", | ||
| "# Select the example results folder used in this tutorial\n", | ||
| "home_folder = Path(\"/nas/homes/niels-1000010/GitHub/pywatemsedem/tests/postprocess/langegracht\")" |
There was a problem hiding this comment.
Can you refer to relative paths?
| ) | ||
|
|
||
|
|
||
| def check_and_create_folder( |
There was a problem hiding this comment.
this was the only function that was tested in test_folders.py. Rremove this test and add new tests for the new fodler.py
There was a problem hiding this comment.
Tests for the postprocessing module must be reveiwed as well.
|
@nielsdevleeschouwer your refactoring is looking good! I really like the similar approach with the factory and the use of modelinput and modeloutput objects. However, some remarks:
I already did some small changes (see my commits), so make sure to pull these updates :) |
2 participants
Overhaul of postprocessing module part 1:
What has been implemented
PostProcessobject for a scenario.nselection,sedi_export + sewer_in.