-
Notifications
You must be signed in to change notification settings - Fork 0
Dispatch clone via vault token (no github context on dispatch) #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,10 @@ tasks: | |
| with: | ||
| repository: https://github.com/wave-av/cli.git | ||
| ref: ${{ init.commit-sha }} | ||
| github-token: ${{ github.token }} | ||
| # NOTE: the `github` context does not exist on dispatch-triggered runs | ||
| # (only on github/cli triggers). Use a vault-backed read-only PAT instead. | ||
| # One-time setup: rwx vaults secrets set GH_READ_TOKEN=<classic-PAT-repo-read> --vault default | ||
| github-token: ${{ secrets.GH_READ_TOKEN }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This checkout now depends on a long-lived classic PAT. GitHub classic PATs are not read-only, so the secret you’re asking operators to create is broader than a clone-only credential. Use a fine-grained PAT limited to this repo and Prompt for AI agents
Comment on lines
+30
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- workflow files ---'
git ls-files '.rwx/dispatch.yml' '.rwx/*' 'README*' '.github/*' | head -80
printf '%s\n' '--- dispatch workflow ---'
cat -n .rwx/dispatch.yml
printf '%s\n' '--- git/clone references ---'
rg -n -C 4 'git/clone|github-token|GH_READ_TOKEN' .rwx .github README* 2>/dev/null || trueRepository: wave-av/cli Length of output: 3411 🤖 get_repo_knowledge executed:
Length of output: 685 🌐 Web query:
💡 Result: <search_synthesis> <source_evidence> Citations:
Security Misconfiguration Reachability: Internal Use a repository-scoped fine-grained PAT for This workflow only clones 🤖 Prompt for AI Agents |
||
|
|
||
| - key: node | ||
| call: nodejs/install 1.2.0 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The comment calls this a read-only PAT, but classic PAT repository access is write-capable. A leaked token therefore permits repository modification, not only cloning. [comment mismatch]
Assessment: 🟠
Major· 🔁Occurrence: SometimesPrompt for AI Agent 🤖