Skip to content

chore(guard): sync vendored public-repo-guard to canonical - #28

Open
wave-av-release-bot[bot] wants to merge 1 commit into
mainfrom
chore/guard-canonical-sync
Open

wave-av-release-bot[bot] wants to merge 1 commit into
mainfrom
chore/guard-canonical-sync

Conversation

@wave-av-release-bot

@wave-av-release-bot wave-av-release-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Syncs the vendored public-repo-guard trio to the canonical source in wave-foundation/scaffolder/public-repo-guard.

  • adds the internal-ip leak rule (Tailscale-CGNAT 100.64.0.0/10), lockstep with the pre-publish mirror gate
  • reconciles accumulated drift in the vendored copy

Each changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own Secrets + content policy gate re-scans this PR.

🤖 Generated with Claude Code


Open in Devin Review

Summary by cubic

Syncs the vendored public-repo-guard with the canonical source and hardens the CI scan by updating actions/checkout and dropping persisted credentials.

  • New Features

    • Add internal-ip leak rule for Tailscale CGNAT 100.64.0.0/10.
  • Dependencies

    • Update actions/checkout to v7 and set persist-credentials: false to avoid exposing the job token during scanning.

Written for commit 7d41487. Summary will update on new commits.

Review in cubic

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Checkout action version now inconsistent across workflows

This workflow is pinned to checkout v7.0.0 while .github/workflows/lint.yml:16 uses v6.0.3 and .github/workflows/_checks.yml uses v4.3.1 in three places. Not a functional bug, but the other workflows retain the default persist-credentials: true and are drifting; consider aligning pins and applying the same hardening repo-wide.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@macroscopeapp

macroscopeapp Bot commented Aug 4, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Unable to check for correctness in 7d41487. This CI workflow update (actions/checkout version bump and persist-credentials security improvement) is low-risk, but the file is owned by wave-av/core-team and the bot author is not a designated owner. Human review from the code owners is warranted.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants