Skip to content

chore(contracts): correct false TESTING.md → declared absence (no test command) - #39

Merged
yakimoto merged 1 commit into
mainfrom
contract-files/fix-false-testing
Aug 30, 2026
Merged

yakimoto merged 1 commit into
mainfrom
contract-files/fix-false-testing

Conversation

@yakimoto

@yakimoto yakimoto commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

chore(contracts): correct a false TESTING.md → declared absence

What was wrong

The contract-files rollout (E5-FLEET, 2026-08-30) landed a TESTING.md here whose fenced test-contract block declared entry: npm test and a suite running npm test. This repository has no npm test script (re-verified live at clone time: package.json absent or without scripts.test), so the contract named a command that does not exist. The scaffold in contract-files ≤ v0.5.1 rendered that line unconditionally; bot reviewers caught it on the held PRs, and a fleet-wide census found 73 of 166 repos in the same state. A contract that lies is worse than no contract: in observe mode the Stop gate just logs, in block mode it would refuse every close on a command that cannot run.

What this does

  • Removes the false TESTING.md (the scaffold at contract-files v0.5.2 now REFUSES to render a test-contract when no test command is inferable — no-test-command — and that refusal was exercised here, not assumed).
  • Adds .contracts-absent.json declaring test-contract absent with reason no-test-command. That record is what the fleet census reads: this repo is now explicitly without a test contract, rather than silently missing one or falsely carrying one. When a real test command is added, delete the record and run contracts init --families test-contract.
  • PERMISSIONS.md from the same rollout is untouched — it was correct.

Guarantees

One reversible commit; reverting it restores the rollout state exactly. Nothing executes; no gate mode changes. Body kept above the fleet's measured 1,200-character PR floor deliberately.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Note

Low Risk
Documentation and contract-metadata only; no runtime, gate mode, or executable behavior changes.

Overview
Replaces a misleading test contract with an explicit “no test contract” record. The rollout-added TESTING.md claimed npm test as the entry and suite command, but this repo’s package.json has no scripts.test, so the contract could not run and would break stricter gate modes.

Deletes TESTING.md entirely and adds .contracts-absent.json declaring test-contract absent with reason no-test-command, so fleet tooling treats the repo as intentionally without a test contract rather than missing or falsely configured one.

Reviewed by Cursor Bugbot for commit 11df396. Bugbot is set up for automated code reviews on this repo. Configure here.

Review in cubic

@codeant-ai

codeant-ai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your workspace is out of credits. Ask your workspace admin to add credits to resume reviews. Manage billing

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @yakimoto, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 19 hours and 31 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@cursor

cursor Bot commented Aug 30, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_50815644-bdb9-4410-a8fe-8cd1bc45708e)

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 18 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 94 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 333eb29e-da73-414d-9c8d-e1118d134d8c

📥 Commits

Reviewing files that changed from the base of the PR and between 47ec1e6 and 11df396.

📒 Files selected for processing (2)
  • .contracts-absent.json
  • TESTING.md

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR corrects a misleading generated test contract by removing TESTING.md and adding the fleet-readable .contracts-absent.json declaration for the absence of an inferable test command; no commands, gate modes, or permissions behavior are changed.

File-Level Changes

Change Details Files
Replace the invalid test contract with an explicit declaration that this repository has no test command.
  • Delete the generated TESTING.md containing the unusable npm test contract.
  • Add .contracts-absent.json recording test-contract as absent with reason no-test-command.
  • Preserve the existing permissions contract and leave gate behavior and execution unchanged.
.contracts-absent.json
TESTING.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gitar-bot

gitar-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by September 1. Add seats for more headroom.
Learn more

Code Review ✅ Approved

Removes the false TESTING.md contract that claimed an npm test command this repo does not have, and adds .contracts-absent.json declaring test-contract absent with reason no-test-command. This corrects a misleading contract that would break stricter gate modes, replacing it with an explicit record so fleet tooling treats the repo as intentionally without a test contract. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@macroscopeapp

macroscopeapp Bot commented Aug 30, 2026

Copy link
Copy Markdown

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a narrowly scoped correction to contract documentation and metadata: it removes a non-runnable test declaration and records the intentional absence of a test command. Application code, production behavior, APIs, and deployment workflows are unchanged; the limited effect is on external contract discovery.

Not approved because:

  • Credit balance exhausted. Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@yakimoto
yakimoto merged commit 1767745 into main Aug 30, 2026
24 checks passed
@yakimoto
yakimoto deleted the contract-files/fix-false-testing branch August 30, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant