chore(contracts): correct false TESTING.md → declared absence (no test command) - #39
Conversation
…eclared absence in .contracts-absent.json
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
ⓘ Qodo reviews are paused because your workspace is out of credits. Ask your workspace admin to add credits to resume reviews. Manage billing |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_50815644-bdb9-4410-a8fe-8cd1bc45708e) |
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 94 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR corrects a misleading generated test contract by removing TESTING.md and adding the fleet-readable .contracts-absent.json declaration for the absence of an inferable test command; no commands, gate modes, or permissions behavior are changed. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by September 1. Add seats for more headroom. Code Review ✅ ApprovedRemoves the false OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a narrowly scoped correction to contract documentation and metadata: it removes a non-runnable test declaration and records the intentional absence of a test command. Application code, production behavior, APIs, and deployment workflows are unchanged; the limited effect is on external contract discovery. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
chore(contracts): correct a false TESTING.md → declared absence
What was wrong
The contract-files rollout (E5-FLEET, 2026-08-30) landed a
TESTING.mdhere whose fencedtest-contractblock declaredentry: npm testand a suite runningnpm test. This repository has no npm test script (re-verified live at clone time:package.jsonabsent or withoutscripts.test), so the contract named a command that does not exist. The scaffold in contract-files ≤ v0.5.1 rendered that line unconditionally; bot reviewers caught it on the held PRs, and a fleet-wide census found 73 of 166 repos in the same state. A contract that lies is worse than no contract: in observe mode the Stop gate just logs, in block mode it would refuse every close on a command that cannot run.What this does
TESTING.md(the scaffold at contract-files v0.5.2 now REFUSES to render a test-contract when no test command is inferable —no-test-command— and that refusal was exercised here, not assumed)..contracts-absent.jsondeclaringtest-contractabsent with reasonno-test-command. That record is what the fleet census reads: this repo is now explicitly without a test contract, rather than silently missing one or falsely carrying one. When a real test command is added, delete the record and runcontracts init --families test-contract.PERMISSIONS.mdfrom the same rollout is untouched — it was correct.Guarantees
One reversible commit; reverting it restores the rollout state exactly. Nothing executes; no gate mode changes. Body kept above the fleet's measured 1,200-character PR floor deliberately.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Low Risk
Documentation and contract-metadata only; no runtime, gate mode, or executable behavior changes.
Overview
Replaces a misleading test contract with an explicit “no test contract” record. The rollout-added
TESTING.mdclaimednpm testas the entry and suite command, but this repo’spackage.jsonhas noscripts.test, so the contract could not run and would break stricter gate modes.Deletes
TESTING.mdentirely and adds.contracts-absent.jsondeclaringtest-contractabsent with reasonno-test-command, so fleet tooling treats the repo as intentionally without a test contract rather than missing or falsely configured one.Reviewed by Cursor Bugbot for commit 11df396. Bugbot is set up for automated code reviews on this repo. Configure here.